fix: support binding an ipv6 address#75
Merged
jvdprng merged 1 commit intotrailofbits:mainfrom Oct 24, 2025
Merged
Conversation
Contributor
Author
|
I also tried the following to save up the dns request: def family_ip(address):
try:
ipaddress.IPv4Address(address)
return socket.AF_INET
except ipaddress.AddressValueError:
try:
ipaddress.IPv6Address(address)
return socket.AF_INET6
except ipaddress.AddressValueError:
return socket.getaddrinfo(address, 0, type=socket.SOCK_STREAM)[0][0]But it was slower than doing always the dns request The CLA assistant is super cool btw :D |
Member
|
Thanks, just one lint issue but I can fix it! |
Contributor
Author
|
Sorry for the lint issue, we use single-quote-for-technical-string at work and I totally forgot that the rest of the world agrees on using double quotes everywhere. I'll pay attention for future PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #68