chore(tra-974): drop dead BACKEND_LOG_LEVEL key from backend chart - #158
Merged
Merged
Conversation
The trakrf-backend logger reads bare LOG_LEVEL via os.Getenv (logger/config.go) — there is no BACKEND_ prefix scheme, so the chart's config.logLevel → BACKEND_LOG_LEVEL ConfigMap key was never read by the backend (confirmed against the backend source). PR #157 added the real LOG_LEVEL emission (config.runtimeLogLevel); this removes the misleading dead key and its now-orphaned config.logLevel value so the chart is honest. No functional change — BACKEND_LOG_LEVEL was inert. Removing it does change both envs' rendered ConfigMap (key drops out), so the next apply-root-app.sh gke rolls the prod backend pod once (clean restart, no behavior change); preview keeps LOG_LEVEL=info via config.runtimeLogLevel. Verified via helm template: BACKEND_LOG_LEVEL absent from all renders; LOG_LEVEL=info still emits when runtimeLogLevel is set; chart renders clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up cleanup to #157. Removes the dead
BACKEND_LOG_LEVELConfigMap key (and its now-orphanedconfig.logLevelchart value) from the trakrf-backend chart.The backend logger reads bare
LOG_LEVELviaos.Getenv(logger/config.go) — there's noBACKEND_prefix scheme, soconfig.logLevel → BACKEND_LOG_LEVELwas never read by the backend. Confirmed against the backend source. #157 added the realLOG_LEVELemission viaconfig.runtimeLogLevel; this drops the misleading key so the chart is honest.Impact
BACKEND_LOG_LEVELwas inert.scripts/apply-root-app.sh gkerolls the prod backend pod once (clean restart, no behavior change). Preview keepsLOG_LEVEL=infoviaconfig.runtimeLogLevel. Applying in this window with Mike's go-ahead.Verification (
helm template)Tracking: TRA-974.
🤖 Generated with Claude Code