feat(tra-1040): route preview org-lifecycle notices to a single address - #160
Merged
Merged
Conversation
Adds config.orgCreateNotifyAddr → ORG_CREATE_NOTIFY_ADDR (platform PR #524) to the backend chart, emitted only when set, and pins it to mike@kwyk.net for preview via the root chart. Preview's e2e org-creation churn was paging every active superadmin; with the var set all three org-lifecycle notices (signup, create, delete) go to that single address instead. Prod deliberately omits the key and keeps the default superadmin fan-out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
helm/trakrf-backend: newconfig.orgCreateNotifyAddr→ORG_CREATE_NOTIFY_ADDRin the ConfigMap, emitted only when set (same omit-when-empty pattern asruntimeLogLevel).argocd/root: per-env plumbing +preview.orgCreateNotifyAddr: mike@kwyk.net. Prod omits the key.Why
TRA-1040 — org-lifecycle notifications (self-service signup, internal create, delete) fan out to every active superadmin in every env. Preview's e2e org-creation firehose was paging all of them. Backend support merged in trakrf/platform#524: when the var is set, all three notices route to that one address and the fan-out is skipped. Prod keeps the default fan-out.
Verification
helm templateof the root chart emits the key for preview only:Backend ConfigMap renders
ORG_CREATE_NOTIFY_ADDR: "mike@kwyk.net"when set and no key at all when unset; the Deployment consumes it viaenvFrom.configMapRef.Post-merge
Root-chart template/values edits do not auto-sync — requires
scripts/apply-root-app.sh gke(cluster-wide re-render) then a backend pod rollout to pick up the new env.🤖 Generated with Claude Code