fix: misc. endpoints fixes#817
Open
michaldrabik wants to merge 2 commits into
Open
Conversation
Contributor
|
@michaldrabik I'm not entirely sure, but we should keep the passthrough if clients are dependent on data not specified in the schema directly. Safest to just leave it. |
michaldrabik
force-pushed
the
fix/api-sync
branch
from
756da09 to
7de2f63
Compare
Collaborator
Author
|
@rectifyer OK reverted this and band-aided on client generator side for the moment. |
michaldrabik
force-pushed
the
fix/api-sync
branch
from
ee07d85 to
5207316
Compare
Collaborator
Author
|
Added missing my_rating fields. |
vladjerca
requested changes
Jun 26, 2026
| listed_at: z.string().datetime(), | ||
| notes: z.string().nullish(), | ||
| rank: z.number().int(), | ||
| my_rating: z.number().int().nullish(), |
Contributor
There was a problem hiding this comment.
This will be removed, please don't expose.
Collaborator
Author
There was a problem hiding this comment.
Reverted for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rectifyer Is this
passthrough()required? This PR proposes removing it cause it generates some weird artifact in the client.