Mark prompted and setPrompted as deprecated and update confirmed to allow 0#169
Merged
marcinkostecki merged 4 commits intomainfrom Sep 29, 2025
Conversation
marcinkostecki
force-pushed
the
marcinkostecki/res-163-setprompted-doesnt-set-the-prompted-value
branch
from
a1c261c to
8223e0f
Compare
eligrey
reviewed
Sep 24, 2025
| /** Was the UI shown to the user? */ | ||
| /** | ||
| * Was the UI shown to the user? | ||
| * @deprecated |
Member
There was a problem hiding this comment.
We can add deprecation reasons or context here too if we want to expand on this more
Member
Author
There was a problem hiding this comment.
I was initially thinking to do that, but then figured maybe better to have one source of truth, i.e. the AG changelog?
Member
There was a problem hiding this comment.
Fine to have this info duplicated imo, since the changelog is private and this is a public repo
eligrey
previously approved these changes
Sep 24, 2025
marcinkostecki
force-pushed
the
marcinkostecki/res-163-setprompted-doesnt-set-the-prompted-value
branch
from
277fe31 to
1443cd3
Compare
marcinkostecki
force-pushed
the
marcinkostecki/res-163-setprompted-doesnt-set-the-prompted-value
branch
from
1443cd3 to
63c58fd
Compare
marcinkostecki
changed the title
prompted and setPrompted as deprecatedprompted and setPrompted as deprecated and update confirmed to allow 0
eligrey
previously approved these changes
Sep 29, 2025
Member
eligrey
left a comment
eligrey
left a comment
There was a problem hiding this comment.
Might change 'not being set reliably' to 'not being set reliably in some versions' to be more clear
marcinkostecki
force-pushed
the
marcinkostecki/res-163-setprompted-doesnt-set-the-prompted-value
branch
5 times, most recently
from
6b4c080 to
688ee9f
Compare
marcinkostecki
force-pushed
the
marcinkostecki/res-163-setprompted-doesnt-set-the-prompted-value
branch
from
688ee9f to
d918a22
Compare
eligrey
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues