Open
Conversation
marcinkostecki
force-pushed
the
marcinkostecki/goom-1272-add-airgap-api-get-modules
branch
from
e9abb67 to
b8a5f42
Compare
marcinkostecki
commented
Dec 24, 2025
| /** Should module be loaded synchronously? (default: false) */ | ||
| sync?: boolean; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
@eligrey is it OK to add ModuleKind and ModuleDescriptor like this?
Member
Author
There was a problem hiding this comment.
And now also ActiveModuleDescriptor?
Member
There was a problem hiding this comment.
Yeah this lgtm! I missed this PR initially
marcinkostecki
force-pushed
the
marcinkostecki/goom-1272-add-airgap-api-get-modules
branch
from
b8a5f42 to
558b827
Compare
marcinkostecki
force-pushed
the
marcinkostecki/goom-1272-add-airgap-api-get-modules
branch
from
558b827 to
2c4eeb4
Compare
eligrey
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues