Skip to content

🤖 add metadata and getMetadata to AirgapAPI#188

Closed
super-goose wants to merge 2 commits intomainfrom
super-goose/add-airgapmetadata-type
Closed

🤖 add metadata and getMetadata to AirgapAPI#188
super-goose wants to merge 2 commits intomainfrom
super-goose/add-airgapmetadata-type

Conversation

@super-goose
Copy link
Copy Markdown
Member

@super-goose super-goose commented Feb 19, 2026

Related Issues

The new AirgapMetadata type and related types are coming from this file in the main repo.

Comment thread src/core.ts
/** Type override */
export type AirgapMetadata = t.TypeOf<typeof AirgapMetadata>;

/** airgap.js API */
Copy link
Copy Markdown
Member Author

@super-goose super-goose Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red from above was moved down here, because AirgapMetadata relies on some types that were defined after AirgapAPI. From here on out, the "added" code matches the removed code from above, with the addition of getMetadata() (line 844) and metadata (line 727) properties.

@super-goose super-goose requested review from a team February 19, 2026 21:43
Comment thread src/core.ts
][];

/** airgap.js settings or load options (minimal shape for metadata) */
export const AirgapSettings = t.partial({});
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this part; in the main repo, AirgapSettings has a ton of properties, but is assigned to loadOptions. The consent-ui-v2 loadOptions looks nothing like the definition in the main repo.

@super-goose super-goose marked this pull request as draft February 19, 2026 21:58
@super-goose
Copy link
Copy Markdown
Member Author

Will revisit this later, when time allows. Closing for now to prevent recurring reminders.

@super-goose super-goose removed request for a team February 20, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant