Draft
Conversation
eligrey
reviewed
Sep 25, 2020
| const outputWritable = getOutputWritable({ long: true }); | ||
|
|
||
| try { | ||
| const promise = readable.pipeTo(outputWritable); |
Member
There was a problem hiding this comment.
Suggested change
| const promise = readable.pipeTo(outputWritable); | |
| const controller = new AbortController(); | |
| const { signal } = controller; | |
| const promise = readable.pipeTo(outputWritable, { signal }); | |
| controller.abort(); |
I think our abortion semantics should use AbortController, so you can pass in signal here.
Member
Author
|
https://developer.mozilla.org/en-US/docs/Web/API/AbortController Haven't used this before. Looks good though. Does this change the implementation (given our class extends |
Member
|
This will change our implementation and also add an additional API surface to for API consumers to input an AbortController (probably during conflux.Writer instantiation). |
Member
Author
|
@eligrey given transcend-io/penumbra#148 are there any changes required to Conflux for abort handling? |
Member
|
It doesn't seem like it's actually necessary to expose an explicit AbortController in Conflux with Penumbra's wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug wasn't caught by tests.
This PR is currently in the test-writing stage, not bugfix. Closes #56