Skip to content
This repository was archived by the owner on Mar 27, 2026. It is now read-only.

feat(preferences): add optional birthDate to PreferenceUpdateItem #288

Merged
jmenestr merged 3 commits into from
Mar 12, 2026
+2 −0
Merged

feat(preferences): add optional birthDate to PreferenceUpdateItem #288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1655656
feat(preferences): add optional birthDate to PreferenceUpdateItem
jmenestr Mar 11, 2026
ab07a94
docs(preferences): clarify birthDate formats and enforcement location
jmenestr Mar 11, 2026
9af0e33
Merge branch 'main' into feat/preference-update-item-birthdate
jmenestr Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ export const PreferenceUpdateItem = t.intersection([
value: t.union([t.string, t.null]),
}),
),
/** User birthdate. Optional. Accepted formats: YYYY-MM-DD, YYYY-MM, or MM-YYYY. Format enforcement is in the main repo. */
birthDate: t.string,
Copy link
Copy Markdown
Member

@dipack95 dipack95 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noob question -- shouldn't this be in the metadata object?

Copy link
Copy Markdown
Contributor Author

@jmenestr jmenestr Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipack95 we are moving it to the top level

Copy link
Copy Markdown
Contributor Author

@jmenestr jmenestr Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in the metadata object for the initial implementation but we are making it a bit more general beyond just costco.

/** Options to configure the upsert behavior */
options: t.partial({
/**
Expand Down
Loading