refactor(cli): migrate from inquirer to @inquirer/prompts#65
Open
michaelfarrell76 wants to merge 2 commits intomainfrom
Open
refactor(cli): migrate from inquirer to @inquirer/prompts#65michaelfarrell76 wants to merge 2 commits intomainfrom
michaelfarrell76 wants to merge 2 commits intomainfrom
Conversation
Replace legacy `inquirer@^8` + `inquirer-autocomplete-prompt` with the modern `@inquirer/prompts` package. Each prompt call site now uses standalone functions (select, confirm, input, search, checkbox) instead of the deprecated `inquirer.prompt([...])` pattern. - Remove inquirer, inquirer-autocomplete-prompt, and their @types - Delete inquirer-autocomplete-prompt.d.ts and helpers/inquirer.ts wrapper - Convert list → select, confirm → confirm, text → input, autocomplete → search, checkbox → checkbox across 11 files - Convert batch inquirer.prompt(array) calls to sequential for-loops
@transcend-io/cli
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/utils
commit: |
TCJackwood
approved these changes
Apr 7, 2026
Member
TCJackwood
left a comment
TCJackwood
left a comment
There was a problem hiding this comment.
Org nit for the message strings, otherwise LGTM
| purposeMapping.valueMapping[value] = preferenceValue; | ||
| purposeMapping.valueMapping[value] = await select({ | ||
| // eslint-disable-next-line max-len | ||
| message: `Choose the preference value for "${preferenceTopic.slug}" value "${value}" associated with purpose "${purposeMapping.purpose}"`, |
Member
There was a problem hiding this comment.
Since we use this same sort of message with different variable inputs lower in this file, plus the max-len eslint issue, may want to consider moving this out into a separate const file and reference this message string to keep things more DRY
| !!CAN_APPLY_IN_BULK[name], | ||
| ); | ||
| columnNameMap[name] = await select<string>({ | ||
| message: `Choose the column that will be used to map in the field: ${field}`, |
Member
There was a problem hiding this comment.
Yeah the more I'm looking, moving all of these string values used as messages in this PR to a separate messages file would be nice, but not required 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inquirer@^8+inquirer-autocomplete-promptwith the modern@inquirer/promptspackageinquirer.prompt([...])to standalone functions (select,confirm,input,search,checkbox)helpers/inquirer.tswrapper,inquirer-autocomplete-prompt.d.ts, and all@types/inquirer*packagesTest plan
pnpm run typecheckpassespnpm run test)Made with Cursor