feat(sdk): move assessment templates, data subjects helper, and code packages to SDK#71
Open
michaelfarrell76 wants to merge 1 commit intomainfrom
Open
feat(sdk): move assessment templates, data subjects helper, and code packages to SDK#71michaelfarrell76 wants to merge 1 commit intomainfrom
michaelfarrell76 wants to merge 1 commit intomainfrom
Conversation
…packages to SDK - Move fetchAllAssessmentTemplates + ASSESSMENT_TEMPLATES GQL to sdk/src/assessments/ - Move ensureAllDataSubjectsExist to sdk/src/data-inventory/ with new EnsureDataSubjectsInput interface - Move createCodePackage, updateCodePackages, syncCodePackages to sdk/src/code-intelligence/ - Delete dead-code syncCookies.ts from CLI (all callers already import from SDK) - All moved functions follow (client, options) signature convention
@transcend-io/cli
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/utils
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncCookies.ts— dead code, all callers already import from@transcend-io/sdkfetchAllAssessmentTemplates+AssessmentTemplateinterface +ASSESSMENT_TEMPLATESGQL tosdk/src/assessments/ensureAllDataSubjectsExisttosdk/src/data-inventory/with newEnsureDataSubjectsInputinterface (replaces CLI'sTranscendInputcodec dependency)createCodePackage,updateCodePackages,syncCodePackagestosdk/src/code-intelligence/withCodePackageInputinterfaceAll moved functions follow the
(client, options)signature convention with optionallogger(consistent with PRs #59-63).Changes
SDK — new files (4)
packages/sdk/src/assessments/fetchAllAssessmentTemplates.tspackages/sdk/src/assessments/gqls/assessmentTemplate.tspackages/sdk/src/data-inventory/ensureAllDataSubjectsExist.tspackages/sdk/src/code-intelligence/syncCodePackages.tsCLI — deleted files (5)
packages/cli/src/lib/graphql/syncCookies.tspackages/cli/src/lib/graphql/fetchAllAssessmentTemplates.tspackages/cli/src/lib/graphql/gqls/assessmentTemplate.tspackages/cli/src/lib/graphql/ensureAllDataSubjectsExist.tspackages/cli/src/lib/graphql/syncCodePackages.tsCLI — updated imports (3)
pullTranscendConfiguration.ts— importsfetchAllAssessmentTemplatesfrom SDKsyncConfigurationToTranscend.ts— importsensureAllDataSubjectsExistfrom SDK, adapts call to new interfacescan-packages/impl.ts— importssyncCodePackagesfrom SDKTest plan
Made with Cursor