This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Don't set data retention time when creating a table #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #331
Problem
We have the DATA_RETENTION_TIME_IN_DAYS snowflake parameter set to 90 at the account level. However, when this target creates a table it's hardcoded to 1 day. This was discovered when we tried to use time travel to investigate a data issue and found we couldn't look back far enough.
#331
Proposed changes
Don't modify the data retention time.
This is technically a breaking change since the existing version always sets the retention time to 1 day.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)