Skip to content

add --subtype filter to lab task list#2049

Merged
greninja merged 13 commits into
mainfrom
add/cli-task-list-subtype-filter
May 14, 2026
Merged

add --subtype filter to lab task list#2049
greninja merged 13 commits into
mainfrom
add/cli-task-list-subtype-filter

Conversation

@greninja

@greninja greninja commented May 12, 2026

Copy link
Copy Markdown
Contributor

Adds --subtype TEXT to lab task list (routes to /list_by_subtype_in_experiment, the same endpoint the UI's Interact tab uses) and surfaces a subtype column in the pretty output. Currently only good to filter out interactive tasks. Users have to infer the non-interactive by deduction.

Ideal follow-up: give non-interactive tasks an explicit subtype tag (currently they show as N/A) so users can filter them out similarly with --subtype <value>.

@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for transformerlab canceled.

Name Link
🔨 Latest commit f7f7f23
🔍 Latest deploy log https://app.netlify.com/projects/transformerlab/deploys/6a05f51febcda9000803fd8b

@polarityinc

polarityinc Bot commented May 12, 2026

Copy link
Copy Markdown

Paragon Review Skipped

Hi @greninja! Your Polarity credit balance is insufficient to complete this review.

Please visit https://app.paragon.run to finish your review.

@dadmobile dadmobile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the "N/A" thing you mentioned...it's now a little more in the user's face because we add subtype in the tape, but my task lists are mostly filled with N/A tasks. I'm not really sure what we can do about that though

@greninja

greninja commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Just to make sure I'm reading you right, are you saying the new subtype filter isn't very useful for users like you
whose tasks are mostly N/A (since --subtype interactive is the only option), or more that the subtype column in such scenarios (mostly N/A values) is visually noisy and annoying?

If it's the filter usefulness thing, one small extension would be to allow --subtype none to filter out tasks without a subtype (i.e. N/A ones). That way users with mostly-N/A task lists could still fetch out those tasks -- but again yeah I don't know what will users make of it or what they'd do with it.

Ideal would be what I initially suggested -- to add a specific subtype to non-interactive tasks (or tasks other than interactive) to filter them out explicitly.

Lmk what you think. Can makes changes accordingly.

Not sure how big of a change would adding a new tag for non-interactive tasks be, but if its slightly out of scope for this, I can work on it in a seperate PR, and leave this as-is for now.

@dadmobile

Copy link
Copy Markdown
Member

Just to make sure I'm reading you right, are you saying the new subtype filter isn't very useful for users like you whose tasks are mostly N/A (since --subtype interactive is the only option), or more that the subtype column in such scenarios (mostly N/A values) is visually noisy and annoying?

No, I'm saying that most tasks in most situations are going to be N/A, and this PR adds a column to task lists showing task type. So the most common situation is that you see a list that is mostly "N/A" which is weird/ugly. I get why we would want this long term...

Your suggestion that we should be using subtype more broadly is valid but we're not going to do that here.

So for now, maybe...we just don't add the column to the list, but we keep the filter?

@greninja

Copy link
Copy Markdown
Contributor Author

Sg! Made the changes.

@greninja greninja merged commit 10d5e9f into main May 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants