add --subtype filter to lab task list#2049
Conversation
✅ Deploy Preview for transformerlab canceled.
|
|
Paragon Review Skipped Hi @greninja! Your Polarity credit balance is insufficient to complete this review. Please visit https://app.paragon.run to finish your review. |
dadmobile
left a comment
There was a problem hiding this comment.
Regarding the "N/A" thing you mentioned...it's now a little more in the user's face because we add subtype in the tape, but my task lists are mostly filled with N/A tasks. I'm not really sure what we can do about that though
|
Just to make sure I'm reading you right, are you saying the new subtype filter isn't very useful for users like you If it's the filter usefulness thing, one small extension would be to allow --subtype none to filter out tasks without a subtype (i.e. N/A ones). That way users with mostly-N/A task lists could still fetch out those tasks -- but again yeah I don't know what will users make of it or what they'd do with it. Ideal would be what I initially suggested -- to add a specific subtype to non-interactive tasks (or tasks other than interactive) to filter them out explicitly. Lmk what you think. Can makes changes accordingly. Not sure how big of a change would adding a new tag for non-interactive tasks be, but if its slightly out of scope for this, I can work on it in a seperate PR, and leave this as-is for now. |
No, I'm saying that most tasks in most situations are going to be N/A, and this PR adds a column to task lists showing task type. So the most common situation is that you see a list that is mostly "N/A" which is weird/ugly. I get why we would want this long term... Your suggestion that we should be using subtype more broadly is valid but we're not going to do that here. So for now, maybe...we just don't add the column to the list, but we keep the filter? |
|
Sg! Made the changes. |
Adds
--subtype TEXTtolab task list(routes to/list_by_subtype_in_experiment, the same endpoint the UI's Interact tab uses) and surfaces asubtypecolumn in the pretty output. Currently only good to filter out interactive tasks. Users have to infer the non-interactive by deduction.Ideal follow-up: give non-interactive tasks an explicit subtype tag (currently they show as N/A) so users can filter them out similarly with
--subtype <value>.