fix(core): strip trailing slash from companionUrl for socket URL

[JammingBen]

A trailing slash produced ws://host//api/<token>, which Companion's router rejects, so remote uploads hung until the socket timeout. Strip it to make the implementation more robust.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2608105

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@uppy/core	Patch
uppy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mifi]

how did you reproduce this? how did you get the trailing slash? also, would it be possible to sign your commits, as we require all commits to be signed?

[JammingBen]

how did you reproduce this? how did you get the trailing slash?

I passed a companionUrl with a trailing slash to the WebDAV companion plugin: https://uppy.io/docs/webdav, resulting in errors when trying to connect to companion. I didn't try with other plugins, but it seemed like a general issue to me.

also, would it be possible to sign your commits, as we require all commits to be signed?

Yep I just pushed again, should be signed now.

[mifi]

note to self: look into whether we can validate it early instead, and give an error if a trailing slash is passed

[mifi]

The socket URL now goes through the same shared stripTrailingSlash helper as the HTTP URLs (and strips repeated slashes) rather than erroring on a trailing slash, because RequestClient.hostname has always silently tolerated one for every HTTP endpoint — so validating would break apps that work fine today, in a patch release.