fix(@uppy/angular): apply initial open value after the plugin mounts - #6494
Open
mifi wants to merge 2 commits into
Open
fix(@uppy/angular): apply initial open value after the plugin mounts#6494mifi wants to merge 2 commits into
open value after the plugin mounts#6494mifi wants to merge 2 commits into
Conversation
Angular runs `ngOnChanges` before `ngOnInit`, and `this.plugin` is only assigned in `ngOnInit` -> `onMount`. So `<uppy-dashboard-modal [open]="true">` threw `TypeError: Cannot read properties of undefined (reading 'openModal')` on the very first change detection pass. Apply the current `open` value in `ngOnInit`, right after the plugin is mounted — the initial value only ever appears in that first `SimpleChanges`, so guarding the call alone would silently drop it. `ngOnChanges` now bails out until the plugin exists and handles only post-mount transitions; on that first pass every input still carries `previousValue: undefined`, so all of its branches were no-ops anyway. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MKvGt7BTgQQ6MxHUWBDWpP
🦋 Changeset detectedLatest commit: f406933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I have no angular experience and cannot verify this:
Angular runs
ngOnChangesbeforengOnInit, andthis.pluginis only assigned inngOnInit->onMount. So<uppy-dashboard-modal [open]="true">threwTypeError: Cannot read properties of undefined (reading 'openModal')on the very first change detection pass.Apply the current
openvalue inngOnInit, right after the plugin is mounted — the initial value only ever appears in that firstSimpleChanges, so guarding the call alone would silently drop it.ngOnChangesnow bails out until the plugin exists and handles only post-mount transitions; on that first pass every input still carriespreviousValue: undefined, so all of its branches were no-ops anyway.Claude-Session: https://claude.ai/code/session_01MKvGt7BTgQQ6MxHUWBDWpP