Skip to content

@uppy/core: upgrade p-retry to v8 - #6495

Open
mifi wants to merge 1 commit into
transloadit:mainfrom
mifi:claude/uppy-issue-6297-cver17
Open

@uppy/core: upgrade p-retry to v8#6495
mifi wants to merge 1 commit into
transloadit:mainfrom
mifi:claude/uppy-issue-6297-cver17

Conversation

@mifi

@mifi mifi commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

See #6297 (comment)

p-retry v6 depends on the unmaintained CJS-only retry package, which prevents some bundler optimizations. v7 dropped that dependency (and improved stack traces as a result); v8 is the current major and matches the repo's Node >=22 engines requirement.

The only API change affecting us is onFailedAttempt, which now receives a RetryContext object instead of the error itself.

Claude-Session: https://claude.ai/code/session_01CZpX3U67tstF1tiMANykeK

@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2608264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

socket-security Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​p-retry@​8.0.010010010083100

View full report

@mifi
mifi force-pushed the claude/uppy-issue-6297-cver17 branch from fb5244f to 2608265 Compare August 26, 2026 12:36
p-retry v6 depends on the unmaintained CJS-only `retry` package, which
prevents some bundler optimizations. v7 dropped that dependency (and
improved stack traces as a result); v8 is the current major and matches
the repo's Node >=22 engines requirement.

The only API change affecting us is `onFailedAttempt`, which now receives
a `RetryContext` object instead of the error itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CZpX3U67tstF1tiMANykeK
@mifi
mifi force-pushed the claude/uppy-issue-6297-cver17 branch from 2608265 to 2608264 Compare August 26, 2026 12:40
@mifi
mifi requested a review from qxprakash August 26, 2026 12:41
@mifi mifi mentioned this pull request Aug 26, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant