Skip to content

Better MLDSA generate func name #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCutter merged 1 commit into from
May 5, 2026
+6 −6
Merged

Better MLDSA generate func name #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions note/note_cosigv1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ const (
)


// GenerateMLDSASignerKey generates a named signer and verifier key pair. The signer key skey is private and must be kept secret.
func GenerateMLDSASignerKey(name string) (skey string, vkey string, err error) {
// GenerateMLDSAKey generates a named signer and verifier key pair. The signer key skey is private and must be kept secret.
func GenerateMLDSAKey(name string) (skey string, vkey string, err error) {
if !isValidName(name) {
return "", "", errSignerID
}
Expand Down
8 changes: 4 additions & 4 deletions note/note_cosigv1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ func TestMLDSAInvalidTimestamp(t *testing.T) {
}
}

func TestGenerateMLDSASignerKey(t *testing.T) {
func TestGenerateMLDSAKey(t *testing.T) {
for _, test := range []struct {
name string
wantErr bool
Expand All @@ -342,7 +342,7 @@ func TestGenerateMLDSASignerKey(t *testing.T) {
},
} {
t.Run(test.name, func(t *testing.T) {
skey, vkey, err := GenerateMLDSASignerKey(test.name)
skey, vkey, err := GenerateMLDSAKey(test.name)
if gotErr := err != nil; gotErr != test.wantErr {
t.Fatalf("GenerateMLDSASignerKey(%q) error = %v, wantErr %v", test.name, err, test.wantErr)
}
Expand Down Expand Up @@ -382,9 +382,9 @@ func mustGenerateEd25519Key(t *testing.T, name string) (string, string) {

func mustGenerateMLDSAKey(t *testing.T, name string) (string, string) {
t.Helper()
skey, vkey, err := GenerateMLDSASignerKey(name)
skey, vkey, err := GenerateMLDSAKey(name)
if err != nil {
t.Fatalf("GenerateMLDSASignerKey(%q): %v", name, err)
t.Fatalf("GenerateMLDSAKey(%q): %v", name, err)
}
return skey, vkey
}
Loading