Skip to content

Remove Cloud Run VPC #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phbnf merged 1 commit into from
Jun 26, 2025
Merged

Remove Cloud Run VPC #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deployment/modules/gcp/cloudrun/README.md.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Cloud Run

## Tips

You may want to attach your service to a VPC to allow for [better throughput](https://cloud.google.com/run/docs/configuring/networking-best-practices#direct-vpc-throughput).
10 changes: 0 additions & 10 deletions deployment/modules/gcp/cloudrun/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,6 @@ resource "google_cloud_run_v2_service" "default" {
}
}
}
// Attach a VPC for better throughput:
// https://cloud.google.com/run/docs/configuring/networking-best-practices#direct-vpc-throughput
vpc_access {
network_interfaces {
network = "default"
subnetwork = "default"
tags = ["tesseract",]
}
egress = "ALL_TRAFFIC"
}
}

deletion_protection = false
Expand Down
Loading