add move hardlinks functionality to consolidate tool #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanando
changed the title
added 2 commits
March 29, 2024 09:18
foux
reviewed
Dec 1, 2025
| print(f"rm {to_be_deleted}") | ||
| if execute: | ||
| # create dir on tgt if needed | ||
| os.makedirs(os.path.dirname(to_be_linked), exist_ok=True) |
There was a problem hiding this comment.
There is an issue with this line. The dirs will be created as root and won't preserve the attributes of the source
Owner
|
One reason I didn't include this PR is honestly I just forgot to look into this. But a better reason is that inode alone is not sufficient to confirm files are the same. Not all filesystems guarantee inodes are unique in that way. In the very least, assuming the code functioned as expected, that limitation should be noted somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I came across this tool and it almost fit my use case. The only missing part was being able to also copy all associated hardlinks, so I added this functionality.