Use union instead of intersection for attributes#55
Draft
trask wants to merge 1 commit into
Draft
Conversation
trask
force-pushed
the
fix/union-span-event-attrs
branch
3 times, most recently
from
df05200 to
9b3dca2
Compare
trask
changed the title
trask
changed the title
Span per_type_attrs and event_attrs were using intersection_update, meaning an attribute was only counted as present if it appeared in every sample. Changed to union so an attribute is present if it appears in any sample. Also removed the now-redundant per_type_any_attrs field since it is identical to per_type_attrs after this fix.
trask
force-pushed
the
fix/union-span-event-attrs
branch
from
9b3dca2 to
61787e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are pros/cons, probably need to think more about this...