Open
Conversation
3a5c009 to
15acc58
Compare
Author
|
fa80748 also shows the change of the order. The issue is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1105.
On "Git Bash" on Windows, the
dplexecutable runscmd.exe, which does not play well with thebashsyntax. Thus, I added a check to be on Windows and then executebash.exe.This required
osto check for WindowsKernel.systemtoshellI also fixed the
setupphase. Thegit configcommand was called inside the source directory (which typically is not a.gitdirectory) and not in the target directory (which is the git repository being pushed).Tested on Windows with a GitHub repository.
Minor fix: typo