Conversation
svenfuchs
left a comment
There was a problem hiding this comment.
this looks quite good to me @adrianbroher! i am wondering if the log output will be very useful if we omit the work dir from it, and i'm not sure we need the dst_dir method at all if it's just eqal to target_dir, but those are rather cosmetic questions.
have you been able to test this with an actual deployment?
you can trigger a deployment with your fork like so:
deploy:
- provider: pages
edge:
repo: adrianbroher/dpl
branch: pages-target-dir
# ...| git_init: 'Initializing local git repo', | ||
| git_checkout: 'Checking out orphan branch %{target_branch}', | ||
| copy_files: 'Copying %{src_dir} contents to %{work_dir}', | ||
| copy_files: 'Copying %{src_dir} contents to %{dst_dir}', |
There was a problem hiding this comment.
i think this can just be target_dir, in which case we wouldn't need the extra method dst_dir below.
I can add another message to the
I actually wanted to add a guard/limitation so that
No, but I created this test repository.
|
|
While looking at the log of the build it may be a good idea to call |
This PR tries to take a stab at #1164.
Never did anything related to ruby, so feedback is appreciated.