TBT-137 Be able to use environment variables across different repos #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarc-dt
reviewed
Jan 16, 2025
|
|
||
| def account_env_vars | ||
| return @account_env_vars if defined? @account_env_vars | ||
| @account_env_vars = Models::AccountEnvVar.where(owner_type: 'User', owner_id: id) |
gbarc-dt
reviewed
Jan 16, 2025
| @@ -0,0 +1,7 @@ | |||
| module Travis::API::V3 | |||
| class Renderer::AccountEnvVar < ModelRenderer | |||
| representation :standard, :id, :owner_id, :owner_type, :name, :value, :public, :created_at, :updated_at | |||
There was a problem hiding this comment.
if it's not public ,the value shouldn't be read/sent, is it handled somewhere?
gbarc-dt
reviewed
Jan 16, 2025
| def run! | ||
| raise LoginRequired unless access_control.full_access_or_logged_in? | ||
|
|
||
| query(:account_env_var).delete(params, access_control.user) |
There was a problem hiding this comment.
check user roles here, might not be authorized to delete (same for create)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.