Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Dep for Golang builds #1293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DarthHater
Copy link

Hi there,

Out of some need for my own projects, I started a branch to add in dep (seems fairly consistent with godep).

I am not done with this yet, FYI, but wanted to get a PR up so I could figure out if there was anything stupid I'm forgetting. I notice you have app_host for getting binaries for example, I imagine that's to not get punished over hitting github a million times?

@@ -81,6 +81,10 @@ def install
end
end
end
sh.elif '-f Gopkg.toml' do
fetch_dep
sh.cmd 'dep ensure', retry: true, timing: true, assert: true, echo: true

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sh.cmd "curl -sL -o #{dep} https://github.com/golang/dep/releases/download/v0.3.2/dep-linux-amd64", echo: false
end

sh.cmd "chmod +x #{dep}"

This comment was marked as spam.

sh.mkdir "$HOME/gopath/bin", echo: false, recursive: true

sh.if "$TRAVIS_OS_NAME = osx" do
sh.cmd "curl -sL -o #{dep} https://github.com/golang/dep/releases/download/v0.3.2/dep-darwin-amd64", echo: false

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@meatballhat
Copy link
Contributor

@DarthHater Hello and sorry about the long delay! Do you think that this work is still relevant and up to date and should still be considered for merge?

@DarthHater
Copy link
Author

DarthHater commented Nov 9, 2018 via email

@vitalied vitalied force-pushed the master branch 17 times, most recently from 5f52bac to 39a2872 Compare April 6, 2023 15:25
@vitalied vitalied force-pushed the master branch 2 times, most recently from fad231e to 8bff5a8 Compare July 26, 2023 13:52
@vitalied vitalied force-pushed the master branch 2 times, most recently from b550246 to e10c3aa Compare August 2, 2023 13:40
@vitalied vitalied force-pushed the master branch 7 times, most recently from 1a44841 to 4d03828 Compare August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants