-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in Dep for Golang builds #1293
base: master
Are you sure you want to change the base?
Conversation
@@ -81,6 +81,10 @@ def install | |||
end | |||
end | |||
end | |||
sh.elif '-f Gopkg.toml' do | |||
fetch_dep | |||
sh.cmd 'dep ensure', retry: true, timing: true, assert: true, echo: true |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sh.cmd "curl -sL -o #{dep} https://github.com/golang/dep/releases/download/v0.3.2/dep-linux-amd64", echo: false | ||
end | ||
|
||
sh.cmd "chmod +x #{dep}" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sh.mkdir "$HOME/gopath/bin", echo: false, recursive: true | ||
|
||
sh.if "$TRAVIS_OS_NAME = osx" do | ||
sh.cmd "curl -sL -o #{dep} https://github.com/golang/dep/releases/download/v0.3.2/dep-darwin-amd64", echo: false |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@DarthHater Hello and sorry about the long delay! Do you think that this work is still relevant and up to date and should still be considered for merge? |
It might be for others! The go ecosystem still uses Dep quite a bit.
…On Fri, Nov 9, 2018 at 5:14 AM Dan Buch ***@***.***> wrote:
@DarthHater <https://github.com/DarthHater> Hello and sorry about the
long delay! Do you think that this work is still relevant and up to date
and should still be considered for merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1293 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFSZhvis2LPVYy6LFTVepr9oGnRR1xJLks5utY2qgaJpZM4RgokZ>
.
|
5f52bac
to
39a2872
Compare
fad231e
to
8bff5a8
Compare
b550246
to
e10c3aa
Compare
1a44841
to
4d03828
Compare
Hi there,
Out of some need for my own projects, I started a branch to add in dep (seems fairly consistent with godep).
I am not done with this yet, FYI, but wanted to get a PR up so I could figure out if there was anything stupid I'm forgetting. I notice you have
app_host
for getting binaries for example, I imagine that's to not get punished over hitting github a million times?