Enable installing static library for MRI 2.4 and 2.5

[d-unsed]

• Install both static and dynamic libraries for MRI 2.4.x

Hi! There was a breaking change introduced in Ruby 2.4 related to static and shared libraries.

Pre-2.4 behavior:

• always install static library (libruby-static.a)
• with --enable-shared option, additionally install shared library (libruby.x.y.z.so)

2.4.x behavor:

• if no options given, install only static library
• with --enable-shared, install only dynamic library
• with --enable-shared and --enable-install-static-library, install both shared and static libs

By default RVM uses --enable-shared flag. So it means that currently the pre-built rubies for 2.4.x have only shared libs. Some projects (like ruby-sys or ruru) explicitly test linking for both kinds of libraries. So their builds for 2.4.x fail, because those RVM images don't have static libs.

This patch adds --enable-install-static-library to ruby-2.4*, so that their RVM images have both kind of libraries, like 2.3.x and prior versions.

[mpapis]

looks good to me :)

[d-unsed]

@mpapis,

I've implemented a slightly different solution from what you suggested. RVM docs say that custom configure options should be passed as a comma-separated list using -C parameter:

-C            - custom configure options, comma separated, double quote
                args that need quoting, default: --enable-shared=true

Also, I'm definitely not a shell scripting expert, so feel free to request for more changes :)

[mpapis]

The docs is just few options of many, the -- is easier for handling multiple config options with arrays as in my example

…

On Nov 30, 2017 17:04, "Dmitry Gritsay" ***@***.***> wrote: @mpapis <https://github.com/mpapis>, I've implemented a slightly different solution from what you suggested. RVM docs <https://rvm.io/rvm/cli> say that custom configure options should be passed as a comma-separated list using -C parameter: -C - custom configure options, comma separated, double quote args that need quoting, default: --enable-shared=true Also, I'm definitely not a shell scripting expert, so feel free to request for more changes :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC7titqR9vicO8n8QZth3i433WTvcABks5s7tHvgaJpZM4QvNyz> .

[d-unsed]

Got it! I changed to use plain arrays for CONFIGURE_OPTS

[d-unsed]

@mpapis, looks like there was some random failure related to GPG keys in the test env. I've restarted the build, all green now.

[mpapis]

Slight change in new lines, otherwise it's good :)

[d-unsed]

Newlines fixed

[BanzaiMan]

Sorry for overlooking this one. Does this apply to ruby-head these days?