fix: properly parse text starting with a number#12
Merged
clason merged 3 commits intotree-sitter-grammars:masterfrom Nov 13, 2025
flexagoon:number-fix
Merged
fix: properly parse text starting with a number#12clason merged 3 commits intotree-sitter-grammars:masterfrom flexagoon:number-fix
clason merged 3 commits intotree-sitter-grammars:masterfrom
flexagoon:number-fix
Conversation
Contributor
Author
|
cc @clason |
Contributor
Author
|
Since the logic is shared between all grammars except for the separator character, most of the tests only test csv parsing, with two extra tests at the end to test different separators |
Contributor
|
You need to regenerate all three grammars since they all import the changed file (weird that CI didn't pick up on this.) |
Contributor
|
Can you remove this line (as a separate commit)? |
Contributor
Author
|
@clason seems from the CI error like the package-lock has to be removed from gitignore? |
Contributor
|
God, I hate those *#/&%! bindings. |
Contributor
|
Please rebase on master and try again. |
Contributor
|
Can you squash your commits into:
|
Contributor
Author
|
@clason done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #10
Also adds tests