Skip to content

fix: properly parse text starting with a number#12

Merged
clason merged 3 commits intotree-sitter-grammars:masterfrom
flexagoon:number-fix
Nov 13, 2025
Merged

fix: properly parse text starting with a number#12
clason merged 3 commits intotree-sitter-grammars:masterfrom
flexagoon:number-fix

Conversation

@flexagoon
Copy link
Contributor

Supersedes #10

Also adds tests

@flexagoon
Copy link
Contributor Author

cc @clason

@flexagoon
Copy link
Contributor Author

Since the logic is shared between all grammars except for the separator character, most of the tests only test csv parsing, with two extra tests at the end to test different separators

@clason
Copy link
Contributor

clason commented Nov 12, 2025

You need to regenerate all three grammars since they all import the changed file (weird that CI didn't pick up on this.)

@clason
Copy link
Contributor

clason commented Nov 12, 2025

Can you remove this line (as a separate commit)?

@flexagoon
Copy link
Contributor Author

flexagoon commented Nov 12, 2025

@clason seems from the CI error like the package-lock has to be removed from gitignore?

@clason
Copy link
Contributor

clason commented Nov 12, 2025

God, I hate those *#/&%! bindings.

@clason
Copy link
Contributor

clason commented Nov 12, 2025

Please rebase on master and try again.

@clason
Copy link
Contributor

clason commented Nov 13, 2025

Can you squash your commits into:

  1. fix: update tree-sitter version
  2. add tests
  3. the actual fix (squashing the chores into this)

@flexagoon
Copy link
Contributor Author

@clason done

@clason clason enabled auto-merge (rebase) November 13, 2025 10:07
@clason clason merged commit f6bf6e3 into tree-sitter-grammars:master Nov 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants