fix(makefile): improve build reliability and cleanup process#27
Merged
lewis6991 merged 1 commit intotree-sitter-grammars:mainfrom Apr 8, 2025
Merged
fix(makefile): improve build reliability and cleanup process#27lewis6991 merged 1 commit intotree-sitter-grammars:mainfrom
lewis6991 merged 1 commit intotree-sitter-grammars:mainfrom
Conversation
jasonkradams
force-pushed
the
chore/dev
branch
5 times, most recently
from
eea1362 to
6e69cd0
Compare
Contributor
Author
|
There were some attempts to resolve the failing pipeline but after a few attempts I opted to open #29 and work on this in a future PR |
lewis6991
reviewed
Apr 5, 2025
- Make `build` target depend on `clean` to ensure a fresh build - Clean up `build/`, `parser/tcl.so`, and `node_modules/` in the `clean` target
Contributor
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildtarget depend oncleanto ensure a fresh buildbuild/,parser/tcl.so, andnode_modules/in thecleantarget