Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional consequences #134

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented May 16, 2023

No description provided.

@aryx aryx requested a review from jdrouhard May 16, 2023 07:22
@aryx
Copy link
Contributor

aryx commented May 16, 2023

I think you need to regenerate the parser.c code too.

@aryx
Copy link
Contributor

aryx commented May 16, 2023

Not sure why we don't have any CI check working for this repo. Also what is this appveyor thing?

@amaanq amaanq force-pushed the optional-consequence branch from 38d66f9 to f0db9df Compare May 16, 2023 15:55
@amaanq
Copy link
Member Author

amaanq commented May 16, 2023

Whoops, added parser.c changes now. I can add a PR for CI checks as well later today

Appveyor (I believe) is a third party CI/app runner tool thing that Max seems to have added to several parser repos

I'd also like to export preprocIf/preprocessor (would be useful in my objc grammar) if that'd be fine to PR in as well

@aryx
Copy link
Contributor

aryx commented May 16, 2023

That would be great! We should just the same CI we have for the other tree-sitter-xxx repos. Not sure why tree-sitter-c got left behind.

@aryx aryx merged commit 424d014 into tree-sitter:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants