Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle __attribute__ in function declaration #19

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Handle __attribute__ in function declaration #19

merged 3 commits into from
Jun 4, 2019

Conversation

calixteman
Copy link
Contributor

It fixes #18

maxbrunsfeld
maxbrunsfeld reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Modeling it using argument_list seems like a good solution. I just left one comment, and you'll need to regenerate the parser due to merge conflicts.

@maxbrunsfeld maxbrunsfeld merged commit fb9fbd8 into tree-sitter:master Jun 4, 2019
@Arcanemagus Arcanemagus mentioned this pull request Jun 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbrunsfeld maxbrunsfeld maxbrunsfeld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__attribute__ is not handled
2 participants
@calixteman @maxbrunsfeld