Fix precedences of * (deref) and & (address-of) #21
Conversation
| @@ -260,7 +260,6 @@ module.exports = grammar({ | |||
|
|
|||
| type_qualifier: $ => choice( | |||
| 'const', | |||
| 'restrict', | |||
There was a problem hiding this comment.
Did you mean to remove restrict here?
There was a problem hiding this comment.
my bad I should have done this in another commit.
Anyway the keyword is duplicated in the list (just after volatile)
There was a problem hiding this comment.
Oh, no I didn't realize! That's fine I don't mind them being in the same commit. I usually squash PRs anyway, to avoid extra commits of the generated parser.c file.
| prec.left(PREC.UNARY, seq('*', $._expression)), | ||
| prec.left(PREC.UNARY, seq('&', $._expression)) | ||
| prec.left(PREC.CAST, seq('*', $._expression)), | ||
| prec.left(PREC.CAST, seq('&', $._expression)) |
There was a problem hiding this comment.
Maybe we should introduce a new PREC.POINTER constant here, rather than using CAST? Or do you think it's good to explicitly state that pointer operations and casts have the same precedence?
There was a problem hiding this comment.
According to this doc:
https://en.cppreference.com/w/c/language/operator_precedence
cast and deref should have the same precedence.
At the beginning I thought to add PREC.DEREF but after reading this doc I thought it was better to do the same.
Feel free to disagree :)
There was a problem hiding this comment.
Oh, ok great, thanks for explaining. Let's leave it exactly as you have it.
calixteman
force-pushed
the
fix_deref_precedence
branch
from
f8f2cb5 to
aae6ad3
Compare
No description provided.