-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft-specific modifiers #40
Add support for Microsoft-specific modifiers #40
Conversation
@maxbrunsfeld ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very well done, and thanks for the reference link and the thorough tests. I left some feedback which is related to code size optimization and naming.
57cfbfd
to
9fc2289
Compare
Microsoft-specific modifiers are keywords can be used to modify declarators to form derived types. The specification for the modifiers themselves is here: https://docs.microsoft.com/en-us/cpp/cpp/microsoft-specific-modifiers?view=vs-2019
9fc2289
to
dfe8679
Compare
@maxbrunsfeld ; I've addressed the comments and opened tree-sitter/tree-sitter-cpp#79 to reflect the changes on the cpp project. Note that the test on tree-sitter/tree-sitter-cpp#79 won't pass until this is closed as it relies on the 0.17.0 version that I propose here. |
@maxbrunsfeld ping |
dfe8679
to
8b84196
Compare
8b84196
to
130dcc5
Compare
Thanks so much; great work on this. I will try to look at the C++ PR later today. |
The last thing required for tree-sitter/tree-sitter-cpp#79 tests to pass is to tag 88592f1 as |
Microsoft-specific modifiers are keywords can be used to modify declarators to form derived types.
The specification for the modifiers themselves is here:
https://docs.microsoft.com/en-us/cpp/cpp/microsoft-specific-modifiers?view=vs-2019.
If you are OK with these changes, I'll go ahead and open a synchronized PR on the cpp grammar to add the Microsoft modifiers there and fix the error that this PR introduces:
Fixes #41