-
-
Notifications
You must be signed in to change notification settings - Fork 111
parse default const parameters #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse default const parameters #255
Conversation
Thanks so much for tracking the progress on the rustc files. |
72d0a56
to
778d83e
Compare
added the second part with |
778d83e
to
dff6690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more naming change. Thanks for addressing all of this feedback!
dff6690
to
dba80e1
Compare
instead of having two seperate type_parameter rules: `constrained_type_parameter` and `optional_type_parameter`, combine them into one rule with two `optional`s.
dba80e1
to
5269fa0
Compare
Thank you! |
This is a breaking change and should have been marked as such. |
fixes #228.
parse const parameter default assignments. specified in the reference it takes blocks, identifiers and literals (with optional minus).
also fixes some more of the mismatches from #229:
diff