Skip to content

add parsing support for use ::* syntax #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

m4rch3n1ng
Copy link
Contributor

this is modeled after the import-glob-crate test. but i only found out after parsing that this test actually only works on rust 2015, for all other editions it just doesn't work.

if you don't want to support silly rust 2015 features, then i will completely understand if you don't merge this in, i just didn't realize until too late and now i have the fix so i may as well just create a pr anyway

i have patched my rustc-vs-tree-sitter-rust-mismatch finder script to only print tests that also work in rust 2018+, cause i don't really want to waste my time on rust 2015 only features.

the slightly miserable diff of rustc tests:

this is kinda silly
--- .tmp/list.txt	2025-02-28 16:16:12.002933806 +0100
+++ .tmp/list.txt.import-glob-crate	2025-03-01 04:07:23.824110326 +0100
@@ -170,7 +170,6 @@
 tests/ui/implied-bounds/dyn-erasure-no-tait.rs
 tests/ui/implied-bounds/dyn-erasure-tait.rs
 tests/ui/imports/extern-crate-used.rs
-tests/ui/imports/import-glob-crate.rs
 tests/ui/imports/local-modularized-tricky-pass-2.rs
 tests/ui/inline-const/const-match-pat-inference.rs
 tests/ui/inline-const/const-match-pat-range.rs

@maxbrunsfeld maxbrunsfeld merged commit bb08b6f into tree-sitter:master Mar 6, 2025
4 checks passed
@maxbrunsfeld
Copy link
Contributor

Thank you!!

@m4rch3n1ng m4rch3n1ng deleted the import-glob-crate branch March 6, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants