fix(community): load the MIT remote map over https#2315
Open
jim-daf wants to merge 1 commit into
Open
Conversation
CommunityFragment fed the community map WebView a cleartext URL (http://maps.media.mit.edu/remote.html). maps.media.mit.edu serves the same page over https, so the swap is a one-character change that drops the cleartext leg of this load and the privacy hole that goes with it (passive network observers can no longer see who visits the page and tamper with the response). Tracker / community behaviour does not change since the page itself is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2314.
CommunityFragmentloads the community map WebView with a cleartext URL:bind.map.loadUrl("http://maps.media.mit.edu/remote.html")maps.media.mit.eduserves the same page over https, so the swap is a one-character change. Drops the cleartext leg of this load and the passive-observer on-path-injection surface that came with it. The app still keeps its globalusesCleartextTraffic="true"for now, but that flag can eventually be dropped once every remaining cleartext call site is migrated too.Change
kotlin
- bind.map.loadUrl("http://maps.media.mit.edu/remote.html")+ bind.map.loadUrl("https://maps.media.mit.edu/remote.html")