Skip to content

Commit 23b7f09

Browse files
N-o-Zclaude
andauthored
Remove unimplemented endpoints and Enterprise-only parameters from OpenAPI (#10370)
* Remove unimplemented endpoints and Enterprise-only parameters Strips pure-stub handlers that always return 501 in the Community edition from the OpenAPI spec, along with Enterprise-only request parameters, so the OSS swagger accurately reflects the Community API surface. Endpoints removed (pure stubs — always 501 in OSS): - getTokenRedirect, getTokenFromMailbox, releaseTokenToMailbox - commitAsync, commitAsyncStatus - mergeIntoBranchAsync, mergeIntoBranchAsyncStatus - getLicense - pushIcebergTable, pullIcebergTable Schemas removed (no remaining references): - License, IcebergPushRequest, IcebergPullRequest, IcebergLocalTable, IcebergRemoteTable, IcebergNamespaceRef - AsyncTaskStatus, CommitAsyncStatus, MergeAsyncStatus Enterprise-only parameters removed: - storage_id on RepositoryCreation (kept on Repository response) - async_ops flag in CapabilitiesConfig Conditional-501 endpoints (RBAC policies/users/groups, external principals, presign multipart, expired-object 410s) are preserved — they have real implementations under other configurations. Regenerated pkg/api/apigen and the Python / Java / Rust SDKs. The openapi-breaking-changes CI will fail — intentional, since the removed endpoints were never implemented in the Community edition. Note: the lakectl source in this branch will not compile on its own because some commands still call methods that were removed from the regenerated API client. The follow-up lakectl cleanup lives in a stacked PR based on this branch. * lakectl: clean up commands after OpenAPI endpoint removal (#10373) Stacked on top of the OpenAPI cleanup PR. Removes the lakectl commands and flags whose only backing endpoints are no longer in the Community OpenAPI spec. - Remove `lakectl login` (used getTokenRedirect / getTokenFromMailbox, both always 501 in OSS). - Drop the `--async` code paths from `lakectl commit` and `lakectl merge` (called the async endpoints, which were pure stubs; the `AsyncOps` capability flag was hardcoded false so these paths were never taken). - Strip AsyncTaskStatus helpers from `cmd/lakectl/cmd/async.go`. Keep the polling constants (`defaultPollInterval`, `minimumPollInterval`, `defaultPollTimeout`, `ErrTaskNotCompleted`) — still used by `refs dump` / `refs restore`. - Remove the hidden `--storage-id` flag and `withStorageID` helper from `lakectl repo create` / `lakectl repo create-bare`. - Regenerate `docs/src/reference/cli.md`. Co-authored-by: Claude <noreply@anthropic.com> * Restore storage_id on RepositoryCreation Removing the field from the OpenAPI spec would have been a breaking change for existing clients that include it in create-repository requests. Put the field back on the request schema, regenerate clients, restore the handler's use of body.StorageId, and restore the controller and python-wrapper tests that exercised it. * Drop empty getCapabilitiesConfig helper --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2d9b553 commit 23b7f09

140 files changed

Lines changed: 1865 additions & 21550 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

api/swagger.yml

Lines changed: 1 addition & 516 deletions
Large diffs are not rendered by default.

clients/java/README.md

Lines changed: 0 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)