Skip to content

Feature/rclone export support s3 compatible #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/rclone export support s3 compatible #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bff384
feat: added rclone config functionaility for s3 provider
jameshod5 Jan 29, 2025
d78c398
added env variables to config template
jameshod5 Jan 29, 2025
c2cb796
change env names to keep consistency with other tools/workflows
jameshod5 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions deployments/tools/export/lakefs_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
LAKEFS_ACCESS_KEY = os.getenv('LAKEFS_ACCESS_KEY_ID')
LAKEFS_SECRET_KEY = os.getenv('LAKEFS_SECRET_ACCESS_KEY')
LAKEFS_ENDPOINT = os.getenv('LAKEFS_ENDPOINT')
S3_ACCESS_KEY = os.getenv('AWS_ACCESS_KEY_ID')
S3_SECRET_KEY = os.getenv('AWS_SECRET_ACCESS_KEY')
S3_PROVIDER = os.getenv('S3_PROVIDER', default="AWS")
S3_ACCESS_KEY = os.getenv("AWS_ACCESS_KEY_ID")
S3_SECRET_KEY = os.getenv("AWS_SECRET_ACCESS_KEY")
S3_ENDPOINT = os.getenv("AWS_ENDPOINT", default="")

SUCCESS_MSG = "Export completed successfully!"

Expand All @@ -26,8 +28,10 @@ def create_rclone_conf_file():
'lakefs_access_key': LAKEFS_ACCESS_KEY,
'lakefs_secret_key': LAKEFS_SECRET_KEY,
'lakefs_endpoint': LAKEFS_ENDPOINT,
's3_provider': S3_PROVIDER,
's3_access_key': S3_ACCESS_KEY,
's3_secret_key': S3_SECRET_KEY,
's3_endpoint': S3_ENDPOINT
}
res = src.substitute(vars)
with open('rclone.conf', 'w+') as f:
Expand Down
4 changes: 2 additions & 2 deletions deployments/tools/export/rclone.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ force_path_style = true

[s3]
type = s3
provider = AWS
provider = $s3_provider
env_auth = false
access_key_id = $s3_access_key
secret_access_key = $s3_secret_key
region =
endpoint =
endpoint = $s3_endpoint
location_constraint =
acl = private
server_side_encryption =
Expand Down