Extend merge conflicts resolution #9530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
itaigilo
commented
Sep 18, 2025
| "github.com/treeverse/lakefs/pkg/graveler" | ||
| ) | ||
|
|
||
| func BuildConflictsResolver(blockAdapter block.Adapter, valueToPath graveler.ValueToPathFunc) graveler.ConflictsResolver { |
There was a problem hiding this comment.
The ValueToPathFunc is needed by the (Enterprise) conflicts resolver, to get the physical path from a given ValueRecord.
It uses catalog objects, so moving it into graveler creates circular deps.
If you can think of a cleaner way of getting the BuildConflictsResolver access to this ValueToPathFunc, please share.
itaigilo
requested review from
a team,
N-o-Z and
nopcoder
and removed request for
N-o-Z
|
Created V2, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Allowing an extension for the merge conflict resolution logic.
Will be used by the (Enterprise) compaction conflicts resolver.