Skip to content

Add ChecksumCalculation defaults to S3 adapter #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2025
Merged

Add ChecksumCalculation defaults to S3 adapter #9546

merged 4 commits into from
Sep 23, 2025

Conversation

itaigilo
Copy link
Contributor

Updates S3 default, after being updated in the latest aws go sdk changes.

@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Sep 23, 2025
@itaigilo itaigilo requested review from a team, itaiad200 and nopcoder September 23, 2025 11:40
nopcoder
nopcoder approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as temporary workaround; we should have an issue to track how we going to align the implementation of the s3 blockadapter to work with the default behavior of the s3 sdk.

@itaigilo itaigilo merged commit 9c8e0a6 into master Sep 23, 2025
40 checks passed
@itaigilo itaigilo deleted the fix/default-blockstore-checksum-calc branch September 23, 2025 13:42
@itaigilo itaigilo mentioned this pull request Sep 24, 2025
Open
@itaigilo
Copy link
Contributor Author

lgtm as temporary workaround; we should have an issue to track how we going to align the implementation of the s3 blockadapter to work with the default behavior of the s3 sdk.

Added #9551 (will be triaged on Thu).
@nopcoder feel free to add details to the Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nopcoder nopcoder nopcoder approved these changes

@itaiad200 itaiad200 Awaiting requested review from itaiad200

Assignees

No one assigned

Labels

exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itaigilo @nopcoder