feat: enable multiple X-Axis and Y-Axis#1103
Open
alexbalonperin wants to merge 2 commits intotremorlabs:mainfrom
Open
feat: enable multiple X-Axis and Y-Axis#1103alexbalonperin wants to merge 2 commits intotremorlabs:mainfrom
alexbalonperin wants to merge 2 commits intotremorlabs:mainfrom
Conversation
Implemented for AreaCharts, LineCharts & BarCharts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey tremor team, any chance we are planning to add this soon? Would love to have this and see there hasn't been much activity here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented for AreaCharts, LineCharts & BarCharts
Description
This change is quite big because I refactored quite a bit of code to reduce code duplication due to the multiple axis.
It follows the API proposal described in the linked ticket.
This PR was inspired by https://github.com/tremorlabs/tremor/pull/1028 but also supports BarCharts and multiple X-Axis.
A few important things:
I realize that this might be quite a big change that might not get merged quickly (at all?) but since we need it at my company I thought I would make the PR and you can decide if you want to merge or close it.
Related issue(s)
fixes https://github.com/tremorlabs/tremor/issues/1102
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has this been tested?
I have probably looked at the storybook a million times lol.
Screenshots (if appropriate):















The PR fulfils these requirements:
mainbranch