Open
Conversation
Add this prop to select components with search input to retrieve entered text
Member
|
cf #470 |
Member
|
Hey @Lary15 , I have this PR in mind, there will be more confilcts after the next version (3.10) for this PR, so we should park it until November. Will get back to it, thanks! |
|
@severinlandolt did you get a chance to look at this? If this has a chance to get merged soon but the conflicts are an issue I'd be happy to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds onInputValueChange prop to the SearchSelect and MultiSelect component. This is a direct reproduction of #470 PR that is compatible to tremor v3
Related issue(s)
#444
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has This been tested?
With component story examples that demonstrate the intended behavior.
To see it in action, run
npm run storybookand go toInputElements > SearchSelect > With On Input Value ChangeandInputElements > MultiSelect> With On Input Value Change.Screenshots (if appropriate):

The PR fulfills these requirements:
mainbranch