Skip to content

fix: set tooltip trigger type to button#130

Closed
eli-front wants to merge 1 commit intotremorlabs:mainfrom
eli-front:patch-1
Closed

fix: set tooltip trigger type to button#130
eli-front wants to merge 1 commit intotremorlabs:mainfrom
eli-front:patch-1

Conversation

@eli-front
Copy link

@eli-front eli-front commented Mar 28, 2025

Description

Set Tooltip trigger type explicitly to "button" to avoid inferred "submit" type by forms.

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?
limited

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 10:51pm

@severinlandolt
Copy link
Member

@eli-front Updated the requirements. Could you please check the last item, thank you.

@severinlandolt
Copy link
Member

Hi! I Cannot merge this because of the asChild prop. The this would also be applied to any of the children, regardless of their type/element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments