Skip to content

Use fallback Prometheus port in SLES 16 - #134

Open
antgamdia wants to merge 1 commit into
mainfrom
TRNT-4636-fallback-port
Open

Use fallback Prometheus port in SLES 16#134
antgamdia wants to merge 1 commit into
mainfrom
TRNT-4636-fallback-port

Conversation

@antgamdia

Copy link
Copy Markdown
Contributor

Description

This pull request updates the default port configuration for Prometheus to better support SLES 16 environments, where port 9090 is already used by Cockpit. It also improves the documentation to clarify these changes and the related default values.

Prometheus port default changes:

  • Updated the default value of trento_prometheus_port in roles/trento/defaults/main.yml to use port 9191 on SLES 16, while keeping 9090 as the default elsewhere. This prevents port conflicts with Cockpit on SLES 16.
  • Updated the documentation in README.adoc to explain the new default behavior for trento_prometheus_port, specifying that it defaults to 9191 on SLES 16 and can be overridden if needed.
  • Updated the deprecated prometheus_port variable documentation to reflect the new SLES 16 default (9191), improving clarity for users migrating or deploying on SLES 16.

Fixes #TNRT-4636

How was this tested?

IRL

Documentation changes

Yes

Additional information

Related to #132

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia added the enhancement New feature or request label Aug 6, 2026
@antgamdia
antgamdia requested a review from skrech August 6, 2026 13:56
trento_prometheus_host_group: ""
trento_prometheus_host: localhost
trento_prometheus_port: "{{ prometheus_port | default(9090) }}" # `prometheus_port` for backwards-compatibility
trento_prometheus_port: "{{ prometheus_port | default((ansible_distribution_major_version == '16') | ternary(9191, 9090)) }}" # `prometheus_port` for backwards-compatibility; SLES 16 defaults to 9191 since Cockpit already occupies 9090 there

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I would suggest adding a TRENTO_PROMETHEUS_PORT env variable, so that customers can define the best solution there.

thought: And I think more and more than because Prometheus is not supported by Trento and requires additional knowledge to deploy properly, our documentation should specify that. We could then deploy always prometheus in a non-standard port (9191) documenting that is a "test only" solution, and that the customer should deploy their own solution properly in the right port, highlighting the conflict with Cockpit and the reuse of port 9090. That would also avoid problems with customers that expect performance and scalability of the solution to be enough even if that is not part of the solution, and point to MLM as the supported SUSE solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants