Skip to content

Add check for SAPHanaSR-hookHelper configuration - #33

Draft
balanza wants to merge 2 commits into
mainfrom
saphanahook-check
Draft

Add check for SAPHanaSR-hookHelper configuration#33
balanza wants to merge 2 commits into
mainfrom
saphanahook-check

Conversation

@balanza

@balanza balanza commented Mar 17, 2025

Copy link
Copy Markdown
Member

⚠️ DO NOT MERGE
This PR is not completed yet. It exposed an example usage for the newly-introduced sudoers gatherer.

@balanza
balanza requested a review from arbulu89 March 17, 2025 18:20

@arbulu89 arbulu89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Ideally, we would use other gatherer to get the real list of SIDs, and iterate over it instead of getting the unique list of users from the same data.
Either way, the example is nice!

Comment thread checks/206B26.yaml Outdated
@balanza

balanza commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

Ideally, we would use other gatherer to get the real list of SIDs, and iterate over it instead of getting the unique list of users from the same data.

I don't know if it would suit this specific check. The real list of SIDs is file-based and it may include unused SIDs for which the user has been removed.

Hence it would make the check is every SAP user well configured? fail; it would be to combine both information in another check, though, to verify is there an unused SAP system?.

@ksanjeet

ksanjeet commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

I have one check in PR#50 that addresses this requirement. I am getting the SID from ini_files gatherer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants