[TRNT-4376] Move PostgreSQL config to global#192
Conversation
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
There was a problem hiding this comment.
Looks good!
Important to test these changes really carefully as we are really close to release. Specially, a migration for an already deployed k3s with an older postgresql version. We need to be sure that the data that existed before is properly set in the new pod.
@antgamdia please, run those tests.
Yes, that's very true... maybe we can even postpone this change.
Good idea. Ideally, we should have automated upgrade tests in our helm chart CI, though. But, yep, let me double-check manually. Thanks for the heads-up! |
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
|
@arbulu89 , I've tracked the pg update separately; however, some of the changes herein performed can still be useful. > helm template .\charts\trento-server\ | grep "image:" | awk '{print $2}' | tr -d '"' | sort -u
busybox
docker.io/alpine:3.19
docker.io/rabbitmq:3.12.6-management-alpine
ghcr.io/trento-project/checks:1.2.0
ghcr.io/trento-project/trento-wanda:2.0.0
ghcr.io/trento-project/trento-web:3.0.0
k8s.gcr.io/kube-state-metrics/kube-state-metrics:v2.3.0
prom/pushgateway:v1.4.2
quay.io/prometheus/node-exporter:v1.3.0
quay.io/prometheus/prometheus:v2.53.1
registry.k8s.io/kubectl:v1.33.3
registry.suse.com/suse/nginx:1.27
registry.suse.com/suse/postgres:14 |
arbulu89
left a comment
There was a problem hiding this comment.
Nice!
Green light from my side.
Now, updating to a new version will be trivial!
Description
After we discovered some misalignment in the versions used for development (see trento-project/wanda#712 and trento-project/web#4290), we should consistently use a version for our database dependencies.
This PR chooses
17.5as it is the default version being shipped in the OS version we base our images on. As of today, for15 SP7images, the PostgreSQL version is17.5(source). This PR, therefore, sets this version globally.Edit: after some discussions, this PR simply prepares the chart for a future update; not does not perform the actual update.
To make it happen, we moved the image config to the
globalssection and, just for backwards compatibility, we set all the subcharts' values to this new version to avoid further inconsistencies.Related # TRNT-4376
How was this tested?
CI