Update common chart from 1.4.2 to 2.31.9 - #206
Draft
antgamdia wants to merge 13 commits into
Draft
Conversation
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has checked 168 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 64 | 23 | 81 | 0 |
Click to see the invalid file list
- charts/trento-server/charts/common/Chart.yaml
- charts/trento-server/charts/common/templates/_affinities.tpl
- charts/trento-server/charts/common/templates/_capabilities.tpl
- charts/trento-server/charts/common/templates/_compatibility.tpl
- charts/trento-server/charts/common/templates/_errors.tpl
- charts/trento-server/charts/common/templates/_images.tpl
- charts/trento-server/charts/common/templates/_ingress.tpl
- charts/trento-server/charts/common/templates/_labels.tpl
- charts/trento-server/charts/common/templates/_names.tpl
- charts/trento-server/charts/common/templates/_resources.tpl
- charts/trento-server/charts/common/templates/_secrets.tpl
- charts/trento-server/charts/common/templates/_storage.tpl
- charts/trento-server/charts/common/templates/_tplvalues.tpl
- charts/trento-server/charts/common/templates/_utils.tpl
- charts/trento-server/charts/common/templates/_warnings.tpl
- charts/trento-server/charts/common/templates/validations/_cassandra.tpl
- charts/trento-server/charts/common/templates/validations/_mariadb.tpl
- charts/trento-server/charts/common/templates/validations/_mongodb.tpl
- charts/trento-server/charts/common/templates/validations/_mysql.tpl
- charts/trento-server/charts/common/templates/validations/_postgresql.tpl
- charts/trento-server/charts/common/templates/validations/_redis.tpl
- charts/trento-server/charts/common/templates/validations/_validations.tpl
- charts/trento-server/charts/common/values.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| @@ -1,23 +1,25 @@ | |||
| # Copyright Broadcom, Inc. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright Broadcom, Inc. All Rights Reserved. | |
| # SPDX-FileCopyrightText: SUSE LLC | |
| # SPDX-License-Identifier: Apache-2.0 | |
| # Copyright Broadcom, Inc. All Rights Reserved. |
| @@ -1,7 +1,12 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,85 +1,163 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -0,0 +1,46 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,6 +1,11 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -0,0 +1,67 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,35 +1,9 @@ | |||
| {{/* vim: set filetype=mustache: */}} | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,50 +1,10 @@ | |||
|
|
|||
| {{/* vim: set filetype=mustache: */}} | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,3 +1,8 @@ | |||
| {{/* | |||
Contributor
There was a problem hiding this comment.
Suggested change
| {{/* | |
| {* | |
| SPDX-FileCopyrightText: SUSE LLC | |
| SPDX-License-Identifier: Apache-2.0 | |
| *} | |
| {{/* |
| @@ -1,3 +1,8 @@ | |||
| # Copyright Broadcom, Inc. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright Broadcom, Inc. All Rights Reserved. | |
| # SPDX-FileCopyrightText: SUSE LLC | |
| # SPDX-License-Identifier: Apache-2.0 | |
| # Copyright Broadcom, Inc. All Rights Reserved. |
antgamdia
changed the title
common chartcommon chart from 1.4.2 to 2.31.9
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the embedded Bitnami common library chart used by trento-server from 1.4.2 to 2.31.9, bringing in the newer helper templates, warnings/errors, and updated chart metadata/docs needed for compatibility with recent Bitnami chart conventions.
Changes:
- Bump
charts/trento-server/charts/commonto2.31.9(Chart.yaml, README, templates, changelog, notices). - Update/extend common helper templates (capabilities, secrets, affinities, warnings, images, etc.) and align documentation/links.
- Increment
charts/trento-serverchart version to3.2.0-dev6.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| NOTICE | Adds license notice entry for the vendored common chart |
| charts/trento-server/charts/postgresql/templates/NOTES.txt | Removes old upgrade password validation notes snippet |
| charts/trento-server/charts/common/values.yaml | Adds upstream header/docs metadata |
| charts/trento-server/charts/common/templates/validations/_validations.tpl | Adds upstream header |
| charts/trento-server/charts/common/templates/validations/_redis.tpl | Updates redis validation helpers; adds standardized-version detection helper |
| charts/trento-server/charts/common/templates/validations/_postgresql.tpl | Removes old postgresql password validation helper; retains other helpers |
| charts/trento-server/charts/common/templates/validations/_mysql.tpl | Adds mysql validation helper file |
| charts/trento-server/charts/common/templates/validations/_mongodb.tpl | Removes old mongodb password validation helper; keeps other helpers |
| charts/trento-server/charts/common/templates/validations/_mariadb.tpl | Adds header; adjusts existingSecret empty-string handling |
| charts/trento-server/charts/common/templates/validations/_cassandra.tpl | Removes old cassandra password validation helper; keeps other helpers |
| charts/trento-server/charts/common/templates/_warnings.tpl | Updates rolling-tag link and adds additional warnings helpers |
| charts/trento-server/charts/common/templates/_utils.tpl | Updates secret-get instructions and adds checksumTemplate helper |
| charts/trento-server/charts/common/templates/_tplvalues.tpl | Enhances tpl rendering with optional scope + merge helpers |
| charts/trento-server/charts/common/templates/_storage.tpl | Updates storageClass resolution logic |
| charts/trento-server/charts/common/templates/_secrets.tpl | Reworks secret/password helper behavior and lookup logic |
| charts/trento-server/charts/common/templates/_resources.tpl | Adds resource preset helper |
| charts/trento-server/charts/common/templates/_names.tpl | Adds namespace override helper and dependency fullname helper |
| charts/trento-server/charts/common/templates/_labels.tpl | Adds customizable label rendering/merging logic |
| charts/trento-server/charts/common/templates/_ingress.tpl | Simplifies ingress backend generation and adds cert-manager annotation detection |
| charts/trento-server/charts/common/templates/_images.tpl | Adds digest/appVersion fallback behavior and pullSecrets rendering helper |
| charts/trento-server/charts/common/templates/_errors.tpl | Adds insecure images error helper and improves wording |
| charts/trento-server/charts/common/templates/_compatibility.tpl | Adds OpenShift-oriented securityContext rendering helper |
| charts/trento-server/charts/common/templates/_capabilities.tpl | Modernizes apiVersion helpers; adds new capability helpers |
| charts/trento-server/charts/common/templates/_affinities.tpl | Adds enhanced pod affinity support (extra namespaces/terms/etc.) |
| charts/trento-server/charts/common/README.md | Updates docs for new helpers/OCI usage and adds BSI information |
| charts/trento-server/charts/common/Chart.yaml | Bumps chart metadata to 2.31.9 and updates annotations/links |
| charts/trento-server/charts/common/CHANGELOG.md | Adds upstream changelog |
| charts/trento-server/charts/common/.helmignore | Ignores img/ and CHANGELOG.md |
| charts/trento-server/Chart.yaml | Bumps parent chart version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- if $secret }} | ||
| {{- if index $secret.data .key }} | ||
| {{- $password = index $secret.data .key }} | ||
| {{- $secretData := (lookup "v1" "Secret" (include "common.names.namespace" .context) .secret).data }} |
| */}} | ||
| {{- define "common.secrets.lookup" -}} | ||
| {{- $value := "" -}} | ||
| {{- $secretData := (lookup "v1" "Secret" (include "common.names.namespace" .context) .secret).data -}} |
| topologyKey: kubernetes.io/hostname | ||
| - {{ .context.Release.Namespace }} | ||
| {{- with $extraNamespaces }} | ||
| {{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 8 }} |
| namespaces: | ||
| - {{ $.context.Release.Namespace }} | ||
| {{- with .namespaces }} | ||
| {{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 8 }} |
| topologyKey: kubernetes.io/hostname | ||
| - {{ .context.Release.Namespace }} | ||
| {{- with $extraNamespaces }} | ||
| {{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 6 }} |
Comment on lines
+34
to
+48
| {{/* | ||
| Checks whether the redis chart's includes the standarizations (version >= 14) | ||
|
|
||
| Usage: | ||
| {{ include "common.redis.values.standarized.version" (dict "context" $) }} | ||
| */}} | ||
| {{- define "common.redis.values.standarized.version" -}} | ||
|
|
||
| {{- $standarizedAuth := printf "%s%s" (include "common.redis.values.keys.prefix" .) "auth" -}} | ||
| {{- $standarizedAuthValues := include "common.utils.getValueFromKey" (dict "key" $standarizedAuth "context" .context) }} | ||
|
|
||
| {{- if $standarizedAuthValues -}} | ||
| {{- true -}} | ||
| {{- end -}} | ||
| {{- end -}} |
| | `common.capabilities.ingress.apiVersion` | Return the appropriate apiVersion for ingress. | `.` Chart context | | ||
| | `common.capabilities.rbac.apiVersion` | Return the appropriate apiVersion for RBAC resources. | `.` Chart context | | ||
| | `common.capabilities.crd.apiVersion` | Return the appropriate apiVersion for CRDs. | `.` Chart context | | ||
| | `common.capabilities.policy.apiVersion` | Return the appropriate apiVersion for podsecuritypolicy. | `.` Chart context | |
| | -------------------------------- | ----------------------------------------------------------------- | ---------------------------------------------------------- | | ||
| | `common.warnings.rollingTag` | Warning about using rolling tag. | `ImageRoot` see [ImageRoot](#imageroot) for the structure. | | ||
| | `common.warnings.modifiedImages` | Warning about replaced images from the original. | `ImageRoot` see [ImageRoot](#imageroot) for the structure. | | ||
| | `common.warnings.resources` | Warning about not setting the resource object in all deployments. | `dict "sections" (list "path1" "path2") context $` | |
| pullPolicy: | ||
| type: string | ||
| description: Specify a imagePullPolicy. Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' | ||
| description: Specify a imagePullPolicy.' |
| {{- end -}} | ||
|
|
||
| {{/* | ||
| Return the proper image version (ingores image revision/prerelease info & fallbacks to chart appVersion) |
antgamdia
marked this pull request as draft
August 17, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the common chart (just utilities) version from
1.4.2to2.31.9. It's been a long time since the last occasion we upgraded it, the base chart has evolved significantly. As a consequence, some extra changes/adaptations had to be made.Related TRNT-4394
How was this tested?
Via CI automated upgrade tests. Should be enough for the changes introduced herein.
Documentation changes
No.
Additional information
N/A