Rename s/googleai/google - #4599
Draft
gagandeepb wants to merge 14 commits into
Draft
Conversation
...while using the pulled in deps. The providers list is static since these are known to us. s/googleai/google can be evaluated in a subsequent PR since the latter is a more canonical name from the used dependency's perspective.
Here we remove the existing model/provider config from the Application environment/file and instead point to the newly re-implemented LLMRegistry functions.
We don't need these tests any more. The side-effect that these tests were testing (env loading of models/providers) is no more in existence after the re-implementation of the underlying module.
No more config loading needed by the provider and model factories.
One test deleted since it's behaviour is no more relevant for the currently chosen set of providers (these do not in fact have any models in common). Refactors another test to use the factories in an appropriately parameterized manner.
gagandeepb
commented
Aug 10, 2026
Comment on lines
-28
to
-36
| provider = | ||
| case provider == :googleai do | ||
| true -> | ||
|
|
||
| _ -> | ||
| provider | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is not necessary any more after the rename.
gagandeepb
force-pushed
the
rename-googleai-google
branch
from
August 10, 2026 16:17
37ca5c4 to
63cd783
Compare
gagandeepb
force-pushed
the
rename-googleai-google
branch
from
August 11, 2026 07:27
63cd783 to
59cb371
Compare
gagandeepb
added
enhancement
|
The preview environment for this pull request is ready at 4599.prenv.trento.suse.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s/googleai/google since the latter is a more canonical name in the model/provider scheme of things.
Description
Fixes #
How was this tested?
Documentation changes
Yes / No
Additional information