Skip to content

Update protobuf version and analyze fixes #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions example_protobuf/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ environment:
sdk: '>=3.3.0 <4.0.0'

dependencies:
dio: ^5.7.0
dio: ^5.8.0
flutter:
sdk: flutter
http_parser: ^4.0.2
json_annotation: ^4.9.0
logger: ^2.4.0
protobuf: ^3.1.0
logger: ^2.5.0
protobuf: ^4.0.0
retrofit:

dev_dependencies:
build_runner: ^2.4.0
json_serializable: ^6.8.0
lints: ^4.0.0
json_serializable: ^6.9.5
lints: any
mock_web_server: ^5.0.0-nullsafety.1
retrofit_generator:

Expand Down
4 changes: 4 additions & 0 deletions generator/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 9.2.0

- Update protobuf version to 4.0.0

## 9.1.9

- Fixed issue with `@Part` annotation with toJson() enum values.
Expand Down
7 changes: 2 additions & 5 deletions generator/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ topics:
- rest
- retrofit
- codegen
version: 9.1.8
version: 9.2.0
environment:
sdk: '>=3.3.0 <4.0.0'

Expand All @@ -19,14 +19,11 @@ dependencies:
code_builder: ^4.10.0
dart_style: '>=2.3.7 <4.0.0'
dio: ^5.0.0
protobuf: ^3.1.0
protobuf: ^4.0.0
source_gen: '>=1.5.0 <3.0.0'
retrofit: ^4.4.2

dev_dependencies:
lints: any
source_gen_test: ^1.0.6
test: ^1.25.0
# dependency_overrides:
# retrofit:
# path: ../retrofit
4 changes: 2 additions & 2 deletions retrofit/lib/call_adapter.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// Adapts a Call with return type R into the type of T.
/// e.g. Future<User> to Future<Result<User>>
/// e.g. `Future<User>` to `Future<Result<User>>`
abstract class CallAdapter<R, T> {
T adapt(R Function() call);
}
Expand All @@ -14,7 +14,7 @@ abstract class CallAdapter<R, T> {
/// pass in type parameters for the original call return type and adapted call return type.
/// Note: your adapter subclass must accept a single type parameter(T), where T is
/// the type of the unwrapped response from the original call. e.g.
/// "UserResponse" in "Future<UserResponse>"
/// `UserResponse` in `Future<UserResponse>`
///
/// ```dart
/// class ResultCallAdapter<T> extends CallAdapter<Future<T>, Future<Result<T>>> {
Expand Down
4 changes: 2 additions & 2 deletions retrofit/lib/http.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class HttpMethod {
/// Define how to parse response json
/// If you want to support more, PR is welcome
enum Parser {
/// Each model class must provide 'factory T.fromJson(Map<String, dynamic> json)'
/// Each model class must provide `factory T.fromJson(Map<String, dynamic> json)`
/// For more detail, please visit 'https://github.com/trevorwang/retrofit.dart#type-conversion'
JsonSerializable,

Expand Down Expand Up @@ -204,7 +204,7 @@ class NoBody {
/// @POST("/post")
/// Future<String> example(
/// @Field() int foo,
/// @Field("bar") String barbar},
/// @Field("bar") String barbar,
/// )
/// ```
/// Calling with `foo.example("Bob Smith", "President")` yields a request body of
Expand Down
2 changes: 1 addition & 1 deletion retrofit/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ dependencies:
meta: ^1.8.0

dev_dependencies:
lints: ^4.0.0
lints: any
Loading