Add CurveZMQ support for encrypted message queue binding - #1318
Open
jhawk28 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CurveZMQ support for encrypted message queue binding to enable secure communication with ZeroMQ servers. The changes introduce optional encryption capabilities while maintaining backward compatibility.
- Adds optional CurveZMQ encryption configuration with public/private key pairs
- Implements automatic keypair generation when keys are not provided
- Updates the MQ initialization to support the new curve parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bchain/mq.go | Adds curve parameter to NewMQ function and implements CurveZMQ encryption setup |
| bchain/coins/btc/bitcoinrpc.go | Adds MessageQueueCurve configuration field and updates MQ initialization call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@etimofeeva - any chance this can get a review from the team, this feature would be useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.