fix: name in HyperEVM override - #83
Conversation
obrusvit
commented
Aug 11, 2026
- NETWORK_OVERRIDES[999] set name "HyperEVM", but the generated definitions showed "Hyperliquid": download.py maps the CoinGecko native coin ("hyperliquid") back to the network and unconditionally overwrites network name/shortcut with the coin's.
- Pin coingecko_id/coingecko_network_id directly in NETWORK_OVERRIDES. With coingecko_id pre-set, download.py skips its platform lookup for chain 999, so the network is never registered for enrichment and the name survives.
- Both fields must be pinned: setting only coingecko_id would also skip the DeFiLlama fallback, leaving coingecko_network_id unset and breaking token downloads and the network_to_cid mapping for the chain.
- NETWORK_OVERRIDES[999] set name "HyperEVM", but the generated definitions showed "Hyperliquid": download.py maps the CoinGecko native coin ("hyperliquid") back to the network and unconditionally overwrites network name/shortcut with the coin's.
- Pin coingecko_id/coingecko_network_id directly in NETWORK_OVERRIDES. With coingecko_id pre-set, download.py skips its platform lookup for chain 999, so the network is never registered for enrichment and the name survives.
- Both fields must be pinned: setting only coingecko_id would also skip the DeFiLlama fallback, leaving coingecko_network_id unset and breaking token downloads and the network_to_cid mapping for the chain.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes the generated network name for HyperEVM (chain_id 999) by preventing download.py’s CoinGecko enrichment from overwriting the network’s name/shortcut based on the native coin metadata.
Changes:
- Pin
coingecko_id="hyperliquid"for the HyperEVM network override (chain999) so CoinGecko native-coin enrichment doesn’t overridename/shortcut. - Pin
coingecko_network_id="hyperevm"so CoinGecko token downloads andnetwork_to_cidmapping continue to work even when platform lookup is skipped.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.