Skip to content

fix: name in HyperEVM override - #83

Merged
obrusvit merged 1 commit into
obrusvit/refactor/coins-splitfrom
obrusvit/hyper-evm-fix2
Aug 11, 2026
Merged

fix: name in HyperEVM override#83
obrusvit merged 1 commit into
obrusvit/refactor/coins-splitfrom
obrusvit/hyper-evm-fix2

Conversation

@obrusvit

Copy link
Copy Markdown
Collaborator
  • NETWORK_OVERRIDES[999] set name "HyperEVM", but the generated definitions showed "Hyperliquid": download.py maps the CoinGecko native coin ("hyperliquid") back to the network and unconditionally overwrites network name/shortcut with the coin's.
  • Pin coingecko_id/coingecko_network_id directly in NETWORK_OVERRIDES. With coingecko_id pre-set, download.py skips its platform lookup for chain 999, so the network is never registered for enrichment and the name survives.
  • Both fields must be pinned: setting only coingecko_id would also skip the DeFiLlama fallback, leaving coingecko_network_id unset and breaking token downloads and the network_to_cid mapping for the chain.

- NETWORK_OVERRIDES[999] set name "HyperEVM", but the generated definitions showed "Hyperliquid": download.py maps the CoinGecko native coin ("hyperliquid") back to the network and unconditionally overwrites network name/shortcut with the coin's.
- Pin coingecko_id/coingecko_network_id directly in NETWORK_OVERRIDES. With coingecko_id pre-set, download.py skips its platform lookup for chain 999, so the network is never registered for enrichment and the name survives.
- Both fields must be pinned: setting only coingecko_id would also skip the DeFiLlama fallback, leaving coingecko_network_id unset and breaking token downloads and the network_to_cid mapping for the chain.
@obrusvit
obrusvit requested a review from PrisionMike August 11, 2026 10:54
@obrusvit obrusvit self-assigned this Aug 11, 2026
Copilot AI lite review requested due to automatic review settings August 11, 2026 10:54
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e4950f32-0e24-4673-bc5e-7e7cfdbbf80a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the generated network name for HyperEVM (chain_id 999) by preventing download.py’s CoinGecko enrichment from overwriting the network’s name/shortcut based on the native coin metadata.

Changes:

  • Pin coingecko_id="hyperliquid" for the HyperEVM network override (chain 999) so CoinGecko native-coin enrichment doesn’t override name/shortcut.
  • Pin coingecko_network_id="hyperevm" so CoinGecko token downloads and network_to_cid mapping continue to work even when platform lookup is skipped.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@PrisionMike PrisionMike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@obrusvit
obrusvit merged commit 14fbccb into obrusvit/refactor/coins-split Aug 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants