Skip to content

Deprecate uploading language blob during firmware update #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romanz merged 5 commits into from
Jan 6, 2026
Merged

Deprecate uploading language blob during firmware update #6233

romanz merged 5 commits into from
Jan 6, 2026

Conversation

@romanz
Copy link
Contributor

@romanz romanz commented Dec 9, 2025 •
edited
Loading

Resolves #6103.

@romanz romanz self-assigned this Dec 9, 2025
@trezor-bot trezor-bot bot added this to Firmware Dec 9, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 20753368474

@romanz romanz marked this pull request as ready for review December 9, 2025 13:27
@romanz romanz mentioned this pull request Dec 10, 2025
Closed
@romanz
Copy link
Contributor Author

romanz commented Dec 10, 2025

Rebasing to resolve a merge conflict.

@romanz romanz force-pushed the romanz/rm-lang-on-reboot branch from 7e76576 to 5f15409 Compare December 10, 2025 10:25
@romanz romanz added core Trezor Core firmware. Runs on Trezor Model T and Safe models. trezorlib Python library and the command line trezorctl tool. protobuf Structure of messages exchanged between Trezor and the host python Pull requests that update Python code translations Put this label on a PR to run tests in all languages labels Dec 10, 2025
@romanz romanz requested a review from mmilata December 12, 2025 08:43
@romanz romanz force-pushed the romanz/rm-lang-on-reboot branch from 5f15409 to 18e2c02 Compare December 29, 2025 16:30
@romanz
Copy link
Contributor Author

romanz commented Jan 6, 2026

Rebasing to resolve a protobuf-related conflict.

@romanz romanz force-pushed the romanz/rm-lang-on-reboot branch 2 times, most recently from 7f002ed to 0032cc7 Compare January 6, 2026 15:28
@romanz romanz force-pushed the romanz/rm-lang-on-reboot branch from 0032cc7 to 11db231 Compare January 6, 2026 15:39
mmilata
mmilata approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

common/protob/messages-management.proto
// Length of language blob to be installed before upgrading firmware
optional uint32 language_data_length = 3 [default=0];
// Deprecated (length of language blob to be installed before upgrading firmware)
reserved 3;
Copy link
Member

@mmilata mmilata Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should turn all the [deprecated=true] fields to reserved ... but not in this PR

@romanz romanz merged commit 9c96637 into main Jan 6, 2026
165 checks passed
@romanz romanz deleted the romanz/rm-lang-on-reboot branch January 6, 2026 16:20
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmilata mmilata mmilata approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

@obrusvit obrusvit Awaiting requested review from obrusvit obrusvit is a code owner

Assignees

@romanz romanz

Labels

core Trezor Core firmware. Runs on Trezor Model T and Safe models. protobuf Structure of messages exchanged between Trezor and the host python Pull requests that update Python code translations Put this label on a PR to run tests in all languages trezorlib Python library and the command line trezorctl tool.

Projects

Firmware
Status: 🤝 Needs QA

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate translation blob upload during firmware upgrade

3 participants

@romanz @mmilata